Support Offline : Mon - Fri / 10am - 6pm (GMT +6)

Your Time: Our Time:

Accordion extra code after upgrade to 2.4.5

Featured Lock Resolved Bug
After upgrading to 3.4.5 this extra "> code appears between the header title and the content. So this breaks the accordion function.

http://173.236.80.186/~pmjoomla/index.php?option=com_sppagebuilder&view=page&id=25&Itemid=583

Screen Shot 2019-03-16 at 12.18.52 PM.png

Attachments (1)

  • Screen Shot 2019-03-16 at 12.18.52 PM.png
    Screen Shot 2019-03-16 at 12.18.52 PM.png 171.1 KB

17 Answers

Odin Mayland

More than a month ago #Permalink
oops typo. Upgrade to 3.4.5

Odin Mayland

More than a month ago #Permalink
I'm wondering if this has to do with issues with bootstrap 4....

Odin Mayland

More than a month ago #Permalink
This is the code I had in the accordion title that was working fine before the update.


<div class="container">
<div class="row">
<div class="col d-sm-block d-md-none">
{article}
<div class="container">
<div class="row">
<div class="col-sm">Model
</div>
<div class="col-sm">[product label="only"]
</div>
<div class="col-sm">[cycles-per-hour label="only"]
</div>
<div class="col-sm">[voltage-phase label="only"]
</div>
<div class="col-sm">[max-gate-weight label="only"]
</div>
<div class="col-sm">[max-leaf-width label="only"]
</div>
</div>
</div>
{/article}
</div>
<div class="col">
<div class="container text-center">
<div class="row">
{article 79}
<div class="container">
<div class="row">
<div class="col-sm">[title]
</div>
<div class="col-sm">[product]
</div>
<div class="col-sm">[cycles-per-hour]
</div>
<div class="col-sm">[voltage-phase]
</div>
<div class="col-sm">[max-gate-weight]
</div>
<div class="col-sm">[max-leaf-width]
</div>
</div>
</div>
{/article}
</div>
</div>
</div>
</div>
</div>



Odin Mayland

More than a month ago #Permalink
I think the issue is with the aria-label


<span class="sppb-panel-title" aria-label="<div class=" container"="">


Since I am using HTML in the title, the aria-label appears to be causing the issue.

How do I resolve the issue aria-label or how do I remove it?

Odin Mayland

More than a month ago #Permalink
I found the location of the "> code that is displayed:

$output .= '<span class="sppb-panel-title" aria-label="'.trim($item_title).'">';



Is this a bug or is there a way to allow the title to have html in it again like what was working before the update?

Al Mamun - Staff

More than a month ago #Permalink
Hi,

We are sorry to say that it is a bug. It will fixed in next update. If you have urgency I can send you a new package with fix.

Thanks,
Mamun

Al Mamun - Staff

More than a month ago #Permalink
Hi, did you override the Accordion addon? I have checked that there is no problem at all. If you override addon please remove the aria-hidden attribute from your code it will fine.

Thanks,
Mamun

Al Mamun - Staff

More than a month ago #Permalink
Hi,

Please download(again) new version and install. Hope your problem will be fixed.

Thanks,
Mamun

Odin Mayland

More than a month ago #Permalink
Hi, did you override the Accordion addon? I have checked that there is no problem at all. If you override addon please remove the aria-hidden attribute from your code it will fine.

Thanks,
Mamun
No I have not overridden the addon. I was only looking for the problem.

Odin Mayland

More than a month ago #Permalink
Hi,

Please download(again) new version and install. Hope your problem will be fixed.

Thanks,
Mamun
I just downloaded and reinstalled the latest download from here https://www.joomshaper.com/downloads/extension/sp-page-builder-pro and cleared cache but I still see the issue:
http://173.236.80.186/~pmjoomla/index.php?option=com_sppagebuilder&view=page&id=25&Itemid=583

Can you give me a special download with the fix or tell me how to fix it?

Odin Mayland

More than a month ago #Permalink
After reinstalling, I do see the code has changed:

$output .= '<span class="sppb-panel-title" aria-label="'.trim(strip_tags($item_title)).'">';


But it is still an issue on my site.

Al Mamun - Staff

More than a month ago #Permalink
Hi,

I have seen there is no ">" sign like previous image. Can you please clear browser and site cache and check that.

Thanks,
Mamun

Odin Mayland

More than a month ago #Permalink
Hi,

I have seen there is no ">" sign like previous image. Can you please clear browser and site cache and check that.

Thanks,
Mamun
Can you also check http://173.236.80.186/~pmjoomla/index.php?option=com_sppagebuilder&view=page&id=18&Itemid=549

Al Mamun - Staff

More than a month ago #Permalink
Hi,

Thanks got it. Do a simple work please it will help you. Override accordion adddon. Go to templates/{your-template}/ folder then create a folder name "sppagebuilder"(without quote) enter that folder then create a folder name "addons"(without quote) then enter the folder and copy the accordion addon paste it in this folder and remove this code aria-label="'.trim(strip_tags($item_title)).'" hope accordion will work fine.

Thanks,
Mamun

Odin Mayland

More than a month ago #Permalink
I did have to end up removing the aria-label code.

I was surprised by the override path. I thought all overrides would be like this: /templates/shaper_helixultimate/html/com_sppagebuilder/addons/accordion/site.php

But like you wrote I had to do this: /templates/shaper_helixultimate/sppagebuilder/addons/accordion/site.php

Al Mamun - Staff

More than a month ago #Permalink
Hi,

I am not aware of about path you are talking about. If that work do that otherwise do like I said.

Thanks,
Mamun

Odin Mayland

More than a month ago #Permalink
Hi,

I am not aware of about path you are talking about. If that work do that otherwise do like I said.

Thanks,
Mamun
I thought all template overrides went in template/html and had a matching folder structure to the original that is being overridden: components/com_sppagebuilder/addons/accordion/site.php


There are no replies made for this post yet.
Be one of the first to reply to this post!

Leaderboard (30 days)

Paul Frankowski

Paul Frankowski

Total Accepted Answers: 133
Toufiq

Toufiq

Total Accepted Answers: 102
Sifat

Sifat

Total Accepted Answers: 66
IP

Ian Proffer

Total Accepted Answers: 1
G

Geert

Total Accepted Answers: 1

116

Templates

299543

Community Users

Newsletter

Don’t miss any updates of our new templates and extensions and all the astonishing offers we bring for you.
We never spam

Joomla! ® name is used under a limited license from Open Source Matters in the United States and other countries. JoomShaper.com is not affiliated with or endorsed by Open Source Matters or the Joomla! Project.

Connect Us