Support Forums

Support Offline : Mon - Fri / 10am - 6pm (GMT +6)

Your Time: Our Time:

Table - add Icon margin BUG

Featured Lock Resolved Bug
Hi guys,
Joomla 3.9.10 + Helix Ultimate 1.1.1 + SP Page Builder 3.6.1 on PHP 7.2.20 - Test Site

Table addon, when I add an Icon addon to a field:

1 - the Icon is added with Size: 36 + Width: 96 + Height: 96. Would be better to have empty Width / Height by default... WHat do you think ?

2 - the Icon is added with a margin-bottom: 30px - It have no sense ! It should be 0 by default, no margins. This is why in settings we have "Margin" fields.
Anyway, if below I set Margin fields as "0", nothing happen, the margin value is not overwritten.
Please, Can you confirm and fix it ?

10 Answers

Toufiq - Staff

3 weeks ago #Permalink
Hi there,

Thanks for your query. Please check the

1 - the Icon is added with Size: 36 + Width: 96 + Height: 96. Would be better to have empty Width / Height by default... WHat do you think ?
=> No I do not agree. By default, there should be a default value to view the icon.
the Icon is added with a margin-bottom: 30px - It have no sense ! It should be 0 by default, no margins. This is why in settings we have "Margin" fields.
Anyway, if below I set Margin fields as "0", nothing happen, the margin value is not overwritten.
=> This 30px margin-bottom set for the global configuration. So, it's not changeable

-Thanks

joomleb

3 weeks ago #Permalink
Hi Toufiq,

1 - "By default, there should be a default value to view the icon" = With Size: 36 + Width nad Height not setted the icon is perfectly visible... I'm speaking only about Width nad Height

2 - "This 30px margin-bottom set for the global configuration" = Please, What do you mean exactly ?
"So, it's not changeable " = Is there no way to have back margin=0 ?
As you can see on the test site with that 30px margin-bottom each row gets too high and + means that the icon cannot be verically aligned with the text block field on its left... This mean that Icon addon couldn't be used in the Table fields.
When the Icon addon is added no margin should be added.
It seem there is a little bit of classes confusion in the code there...

Why have the CSS Class field into the Icon settings if it cannot be used ?!? Please, Where is the sense ?

Toufiq - Staff

2 weeks ago #Permalink
Hi there,

Thanks for your reply.

1. By default it has
https://prnt.sc/oof8nh
2. There is no way to set 0px by default.
3. If you no need the CSS class then ignore it and sometimes user need to custom CSS & that's why added

-Thanks

joomleb

2 weeks ago #Permalink
Hi Toufiq,

2 - by default should be margin-bottom: 30px; Ok, so:
3 - "by deafault" mean that I should be able to set:
A - Table addon > Style > Margin: 0px 0px 0px 0px
OR
B - Table addon > CSS class: ... Custom CSS margin: 0px 0px 0px 0px;

But, as I wrote you the margin settings are not applied.
The margin-bottom; 30px; cannot be changed.

This is why I wrote you that "seem there is a little bit of classes confusion in the code there" and, Please, Can you confirm and fix it ?

Toufiq - Staff

2 weeks ago #Permalink
Hi there,

I have to forward to our developer team. Al Mamun Please have a look this post.

-Thanks

Al Mamun - Staff

2 weeks ago #Permalink
Hi joomleb,

There is other margin option in "Style" tab can you please check that also?

Thanks,
Mamun

joomleb

2 weeks ago #Permalink
Hi Al Mamun,
here you have the test site and I sent to you the Super Administrator login:

1A - Table addon > Style > Margin: 0px 0px 30px 0px - by default when a Tab addon is added. This should be the entire Table margin, not the table rows, columns, fileds margins = A margin-bottom 20px is applied to the entire Table, not 30px ! = BUG 1 ?!?
1B - If change Table addon > Style > Margin: 0px 0px 30px 0px to any other values, nothing change to the Table margins = BUG 2 ?!?
1C - Table addon > General > CSS class: blabla Custom > CSS margin: 0px 0px 0px 0px; = the margin-bottom 0px is not applied = BUG 3 ?!? ...only margin-bottom over the 20px will be applied...

2A - Table addon > General > TABLE ROW OPTIONS > Item2 > Item4 > added an Icon addon - by default margin-bottom 20px is applied to the Icon Table field, not 0px ! = BUG 4 ?!?
2B - Table addon > General > TABLE ROW OPTIONS > Item2 > Item4 > Icon addon > Margin: 0px 0px 0px 0px; = the margin-bottom 0px is not applied = BUG 5 ?!? ...only margin-bottom over the 20px will be applied...
2C - Table addon > General > TABLE ROW OPTIONS > Item2 > Item4 > Icon addon > CSS class: testing > Custom CSS margin: 0px 0px 0px 0px; = the margin-bottom 0px is not applied = BUG 6 ?!? ...only margin-bottom over the 20px will be applied... PS if I use the same "testing" CSS class name into the Icon addons I add to the Tab fields, the new margins will be applied only to the first one = BUG 7 ?!?


3A - I can set the margin-bottom: 0px only using the generic CSS class in the CSS Custom:
.clearfix {
margin: 0px 0px 0px 0px !important;
}

But, logically, this is applied to the entire site template.

I'm used to add a lot of icons etc. to the table fields. Would be an enormous work and code to add one by one to the CSS custom file...

3B - The first fix I can think is to appliy to all the addons a margin 0 by default, that would permit to run all the margin fields setting you added into all the addons... Do not you think ?

Al Mamun - Staff

2 weeks ago #Permalink
Hi,

Sorry I am messed up because os so many instruction. Can you please make video screencast for the whole process for the issues? Sorry again for my limitation.

Thanks,
Mamun

joomleb

One week ago #Permalink
Hi Al Mamun,
sure! ...I was recording you the video when I noted on my Test site that the Icon addon bug "2" has been solved, (while the Table addon bug "1" is still there)

Please, Did you work on it on my Test site ? Can you confirm it ?
Please, Can you confirm as you finished, so I'll test it recordering a step by step video for you...

Toufiq - Staff

One week ago #Permalink
Hi there,

He doesn't work on your site. Please capture a video and share with him.

-Thanks


There are no replies made for this post yet.
Be one of the first to reply to this post!

Leaderboard (30 days)

Paul Frankowski

Paul Frankowski

Total Accepted Answers: 127
Sifat

Sifat

Total Accepted Answers: 83
Toufiq

Toufiq

Total Accepted Answers: 71
Pavel

Pavel

Total Accepted Answers: 6
Rifat Wahid Alif

Rifat Wahid Alif

Total Accepted Answers: 5

114

Templates

293310

Community Users

Newsletter

Don’t miss any updates of our new templates and extensions and all the astonishing offers we bring for you.
We never spam

Joomla! ® name is used under a limited license from Open Source Matters in the United States and other countries. JoomShaper.com is not affiliated with or endorsed by Open Source Matters or the Joomla! Project.

Connect Us