Helix Ultimate 2.0.13 Bad Generation offvanvas Color Without Custom Style - Forum | JoomShaper
Awaiting an answer Helix Framework

Helix Ultimate 2.0.13 Bad Generation offvanvas Color Without Custom Style

Asked by Alvaro 3 years ago Last activity 3 years ago

Hello, from my point of view and logic I think the generation of colors for offcanvas should be improved, the explanation is as follows:

  1. The option is available only in Custom Style
  2. If Custom Styles is not active the colors are inherited from the Dropdown of the preset as before.

Based on this, it is understood that if you have Custom Style deactivated, the dropdown colors that must be inherited for the offcanvas are from the preset, not from the custom style, as they are doing in the following code.

$scssVars['offcanvas_menu_icon_color'] = '#000000';
$scssVars['offcanvas_menu_bg_color'] = $this->params->get('menu_dropdown_bg_color');
$scssVars['offcanvas_menu_items_and_items_color'] = $this->params->get('menu_dropdown_text_color');
$scssVars['offcanvas_menu_active_menu_item_color'] = $scssVars['menu_text_active_color'];

Where the correct code would be:

$scssVars['offcanvas_menu_icon_color'] = '#000000';
$scssVars['offcanvas_menu_bg_color'] = $scssVars['menu_dropdown_bg_color'];
$scssVars['offcanvas_menu_items_and_items_color'] = $scssVars['menu_dropdown_text_color'];
$scssVars['offcanvas_menu_active_menu_item_color'] = $scssVars['menu_text_active_color'];

Because now it generates a different offcanvas color than the dropdown when the preset is used, and it doesn't leave you with the question where did that color come from?

Please if you can solve or give a logical explanation of why the Custom Style colors are inherited if this is supposed to be deactivated.

Regards

5 replies

Toufiq Senior Staff

Hi there,

I appreciate you reaching out. I sincerely apologize for this oversight. I need to discuss with our developer team. I will get back to you soon.

-Thanks

Alvaro Asked this

News about this issue?

Toufiq Senior Staff

The team is busy to release the e-commerce product. Need more time. Thanks

Alvaro Asked this

Has this been solved in version 2.0.15?

Paul Frankowski Senior Staff

you can check in changelog / new file, but am afraid that not yet :(

Alvaro Asked this

They have made improvements for when Custom Style is activated. The problem I have reported is for when Custom Styles is disabled.
Regards

Log in to reply.