Bad Value For Height Attribute In Img Tag Of Logo - Question | JoomShaper

Bad Value For Height Attribute In Img Tag Of Logo

A

Alvaro

Helix Framework 11 months ago

The rules say that the height attribute of the <img> tag must have only integers without units of measurement.

But when a logo is selected in helix it generates the attribute height="60px" which is not correct.

Could you please fix this? Or do you now accept PRs on Github? You didn't do that before.

0
4 Answers
Ofi Khan
Ofi Khan
Accepted Answer
Support Agent 11 months ago #177168

Hello Alvaro

There are options to select the height attibute value in px, em, rem or % value. This is why if px is selected, then px is added. Unfortunately, I do not think it is needed to change. We do not accept PRs right now. If you need something to be fixed, then let us know on the Support Forum.

prnt.sc/FvvpCyrrZuw9

Best regards

0
A
Alvaro
Accepted Answer
11 months ago #177216

I don't think I explained it well. It's good that you can select different units of measurement, but that's good for the output in CSS but not in the DOM, in the DOM the output should be: <img src="/images/logos/logo.svg" height="60"> and not <img src="/images/logos/logo.svg" height="60px"> Although it's true that its immediate solution is not a priority, it should be solved along with so many other DOM code validation errors.

A company asked me to validate the DOM code in W3C, it's using Helix and SP Page Builder, I started solving this and was going to put the list of everything here, but I don't see any opening to receive collaboration. On the part of SPPB it generates HUNDREDS (yes hundreds) of warnings for adding the <style> tag inside <div> despite having Production Mode activated, I think you should also take a look at that, ultimately the product is yours.

Best Regards

0
Ofi Khan
Ofi Khan
Accepted Answer
Support Agent 11 months ago #177242

Okay, I understand the issue now. You can also send SPPB issues in details. I will share your findings with the developer team. Thank you for raising the issue.

0
Pavel
Pavel
Accepted Answer
11 months ago #177245

it generates HUNDREDS (yes hundreds) of warnings for adding the <style> tag inside <div>

Hi.

To avoid this, refrain from using SPPB modules. This problem has not been solved for many years

0