This was accepted immeditely so I'll continue - until I get all of my note through. It looks like I can't include any code snippets so I'll try to explain without any code included.
This cp 2010 version no longer gives the deprecation warning but it still doesn't work.
I inserted some alert statements into the default_login.php and found that when on line 88 it tried to set the return, the value was not returned- it was an empty string . I inserted another echo to try to see if other params were returned, one was, another wasn't. You can see the echo responses at ottawaotest.ca/oocj4.
It seem this program is not receiving the value of the login_redirect_menuitem that it needs and that perhaps some of the params are not being returned. I also went into the other site and found it does get the value returned correctly.
Now I am stuck as I don't know how to track back to see what program is calling default_login.php and likely providing the value needed. I don't know if this is a problem with the template , the Joomla code or the PageBuilder code but 2 of them belong to joomshaper so hoping you can help.
One other thing I see - this program asks for the menu item or the redirect URL - I recall seeing some module that gave the option of giving a menu item or a URL for redirect. The login module I find now just asks for a menu. This default_login.php seems to think it was the module that offered the 2 choices but I cannot find that module again.