SPPB 5.4.6 - Feaure Box Issue
Alvaro
Hello. There are problems with the improvements included in the addon in SPPB 5.4.6 and the cases are:
-
If the existing addon has Media (icon, image, both) in the Right position, and also has a class assigned in CSS Class field, in the public part it does not identify the class because in the DOM it does not have the space, currently it generates like this:
sppb-text-rightmy-feature-box-classwhen it should be like thissppb-text-right my-feature-box-class -
If you select Media in Right or Left, the space for the icons is 50% which is not correct, because those 50% are for the width of images and are added.
-
I think that you call this "Responsive Media Position" because now in the DOM instead of generating one addon they generate 4 yeaa ... As it stands now, if I have 8 featurebox addons on a page (because it's the most used one), I'll actually have 32, 24 hidden ones even though I haven't selected different ones for different device positions. I know there are better options to make the media positions responsive, not filling up unnecessary DOM and therefore making it less SEO optimized and consuming a lot of bits everywhere, or did they ask the AI to do this?
Regards
Toufiq
Accepted AnswerHi there,
Thank you for reaching out, and I apologize for any inconvenience caused by this oversight. To better address the issue, could you kindly provide Joomla administrator access? This will enable me to thoroughly investigate the matter and provide you with a prompt resolution.
I appreciate your cooperation and will ensure to get back to you as soon as possible.
Best regards,
Toufiqur Rahman (Team Lead, Support)
Alvaro
Accepted Answerhttps://app.screencast.com/SEXT4YNEy6z2j This is the link to the video where I show what I explained in my first post. It is not possible that for 2 addons you have to generate 8, there are simpler and SEO-friendly ways to do that. Also, if you want to make the alignment responsive, there must be an option to activate it, otherwise many custom classes for the addon with a simple click that changes the alignment for a device will ruin everything, because the classes were created for the configuration of the addon in previous versions, it does not matter if they are classes in CSS files or if they are in the custom of the same addon. Regards
Toufiq
Accepted AnswerGot to the file location
Class issue solution
components/com_sppagebuilder/layouts/addon/html/feature.php
Find out this code
$output .= '<div class="sppb-addon-content-align-right sppb-addon sppb-addon-feature sppb-text-right ' . $class . '">';And replace with this code
$output .= '<div class="sppb-addon-content-align-right sppb-addon sppb-addon-feature sppb-text-right ' . $class . '">';We will fix the other issue on the next update.
-Thanks
Alvaro
Accepted AnswerHi there Toufiq, thanks for your repply.
When you mention "the other issue", do you mean the unnecessary DOM or the 50% width for the icon?
The class problem on new sites can be solved by adding a space, the 50% width for the icons, removing the width for the image, both of which can be done by a basic SPPB user. Although these problems should not exist. The problem is really the unnecessary DOM that they generate for the alignment of the media, are you going to solve that? Regards
Alvaro
Accepted AnswerHi, I must congratulate you for the 5.5.0 release and all the work you have done to introduce dynamic content, congratulations!
I must also thank you for improving the problem with classes and the automatic 50% width for icons.
The unnecessary DOM generation problem that remains hidden for "Responsive Media Position" is still there. Are you going to solve that or not?
You know that this is not good for SEO, also when the addon is customized with fixed or absolute positions and for which you took the alignment selector, changing that (when you want to use the responsive position) will be a disaster. Also if you want to customize an addon you would have to think about the possibilities that it has to be responsive and you add CSS that may never be used. My opinion (I know you don't consider it) would be to eliminate that and make the alignment responsive only with CSS, or if you prefer to keep it, it should have an option to activate or not the Responsive Media position (you have already done it in the case of border and border radius).
Regards
Alvaro
Accepted AnswerThanks for the bug fixes required so far on this addon, the icon container width, class name and unnecessary DOM generation have been fixed.
But there is a new bug that needs to be fixed in SPPB 5.5.2, and that is that if for example I have an initial configuration with the icon or image on the left or another, and for Mobile Landscape I want the icon or image to go to the right or another, this is activated for Mobile Landscape and Tablet Portrait because the display:block that shows this configuration and the display:none that hides the initial configuration does so with the breakpoint of max-width:768px when it should be 767.98px, as well as the breakpoints of the columns and the alignments of SPPB or Boostrap. This happens in all breakpoints because they have done it with max-width 576px, 768px, 992px and 1200px when it should be with 575.98px, 767.98px, 991.98px and 1199.98px
Greetings, I hope they fix it soon
Toufiq
Accepted AnswerYou can try to use the text addon+icon addon. Cause, right now this feature is not available on the featurebox addon. Thanks
Alvaro
Accepted AnswerBut I'm not talking about any new feature, much less requesting it. What I'm reporting is about the "Responsive Icon/Image Position" that you have introduced, it doesn't work as it should, if for example I choose the icon on the left in the general configuration (desktop), and if for Mobile Portrait I choose the Icon in Before (top) configuration, it is not only activated for Portrait but also for Landscape where I do have space and this happens because the breakpoints you use to make display:none and display:block are not the correct ones, which I have explained above.
Summary: Please fix the bug in the "Responsive Media Position" of the feature box, because if you activate it for one resolution it also does it for the next size, because you are not using the correct breakpoint (you are using the min-width of the next resolution), you have to see it in the public part.
Toufiq
Accepted AnswerCaqn you provide me administrator access of your site?
Please watch the video.
https://drive.google.com/file/d/1QNrkbKhKO2736V5uaPwhDzG2CuIIflm0/view
Alvaro
Accepted AnswerHi Toufiq, I took the time to make a video about this topic, even explaining column breakpoints so you can understand where they're failing with Feature Box's new Responsive Media Position. I hope it helps fix the bug.
https://app.screencast.com/i5d6ReNol2FVz
As you can see here in the live editor, it is activated so that the icon is on the left side only in TABLET or smaller, but in the Public part it also affects TABLET PORTRAIT and this is because the breakpoint to make the display: block is at 992px when it should be 991.98px, this is for all breakpoints.
Regards