No Custom Style After Security Update For Helix Ultimate V2.2.10 - Question | JoomShaper

No Custom Style After Security Update For Helix Ultimate V2.2.10

D

deevau

Helix Framework 2 days ago

Hi, i've just installed the new plugin and template but now the custom style is not working. Trying to switch in Advanced "Compile SCSS to CSS and back" as i do after every update but it does not work.

any idea?

0
11 Answers
Rashida Rahman
Rashida Rahman
Accepted Answer
Support Agent 2 days ago #232624

Hi there!

Thanks for reaching out.

I have just tested this with the latest version of Helix Ultimate, and the custom style is working correctly on my end:

https://cleanshot.com/share/6XfvrlVX

Could you please clear your Joomla cache and browser cache completely, then check the issue again?

If the issue still occurs after clearing the caches, please let me know.

Best regards,

0
PH
Peter Hunkeler
Accepted Answer
2 days ago #232623

Same problem here. The look of header and footer changes. While the footer seems to only "forget" the background color, the header is renderes unusable.

This productive website still has Helix 2.2.9: https://tvmettmenstetten.ch

And the dev site runs with 2.2.10 https://dev.tvmettmenstetten.ch Note that this site can only be accessed after basic authentication in the browser. Credentials provided in the hidden content.

I cannot install this security fix!

0
D
deevau
Accepted Answer
2 days ago #232628

The custom style wich was created a few month ago ist not loading. Also if clearing cache...

0
PH
Peter Hunkeler
Accepted Answer
2 days ago #232629

Apoligies from my side. I had turned "SCSS to CSS compilation" in the template's settings just a few days ago based on the recommendation in this thread: https://www.joomshaper.com/forum/question/46297#qa-answer-232132

I have turned the compilation on, reloaded the page and it looks good. Turned compilation off again.

However, this remembers me that the last question in the above mentioned thread has not been answered yet. It really is about when to turn on "SCSS to CSS compilation" ever? It seems I must after a template package update. May I kindly ask you to elaborate on the need of turning on or off on the named thead (instead of here) because the answer would be in proper context there. Thanks.

0
D
deevau
Accepted Answer
2 days ago #232636

seems that it works if "Compile SCSS to css" than "save" and swith back and save again...

1
Rashida Rahman
Rashida Rahman
Accepted Answer
Support Agent 2 days ago #232673

Hi,

Thanks for the information and glad the issue has been solved for you.

Have a nice day!

0
D
David Forés
Accepted Answer
2 days ago #232663

Hi JoomShaper team,

I noticed that in Helix Ultimate 2.2.10 the way custom.css is loaded in:

/templates/shaper_helixultimate/index.php

has changed.

Previously:

$theme->add_css('custom.css');

Now:

$customCssPath = JPATH_THEMES . '/' . $template->template . '/css/custom.css';

if (is_file($customCssPath)) {
    $this->addStyleSheet(
        Uri::root(true) . '/templates/' . $template->template . '/css/custom.css?v=' . filemtime($customCssPath)
    );
}

As a result, the HTML output is now something like:

<link href="/templates/shaper_helixultimate/css/custom.css?v=1777328928" rel="stylesheet">

instead of:

<link href="/templates/shaper_helixultimate/css/custom.css" rel="stylesheet">

Could you please explain the reason for this change?

I understand that the new code checks whether the file exists and adds filemtime() for cache busting, but I would like to know why $theme->add_css('custom.css') was replaced and whether there is any other technical reason behind this change.

Thanks.

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 1 day ago #232713

David, I can explain.

It was change suggested by forum user, to reduce problem with cached custom.css by the browser. Many users compained (in the past) that even with changes made custom.css they don't see them until not clear browser cache etc. And this change in theory should help. But I guess, it made extra problem?!

I also made tests on my own sites, and rules from custom.css file were used. Link to file didn't change. Only extra parametr was added.


If you used CSS compression from Template Options , indeed... that file is not used then. We have to correct that area. In the meantime, I think you have to recover php line from v2.2.9 in index.php. And it will be as it was. OR disable CSS compression.

0
D
David Forés
Accepted Answer
1 day ago #232747

In my case, it was just curiosity. I haven't had any problems (I'm not currently using compression).

And yes, when it comes to caching, you have to consider not only browser-level caching but also potential server-side caching, both at the Joomla level and, for example, with LiteSpeed Cache.

Thanks for the reply.

0
PH
Pascal - HTProtect.org
Accepted Answer
1 day ago #232729

If you used CSS compression from Template Options , indeed... that file is not used then. We have to correct that area.

The custom.css with the compression option enabled is still there but loaded before the compressed CSS, in the wrong order - that seems to be the problem.

It should be loaded after the compressed CSS, because it often overrides some of the styles. Alternatively, it could be merged into the compressed CSS at the end.

I was made aware of this through this thread while inspecting with compression turned off and on: https://forum.joomla.de/thread/23883-security-update-for-helix-ultimate-v2-2-10/

0
BOFHJunior
BOFHJunior
Accepted Answer
17 hours ago #232758

Same problem here. If i use "Compress CSS Files" = On, the color changes made under Presets are not used.

But i am still using Helix Ultimate V2.2.9 so this issue was introduced earlier.

0