JQuery V1.12.4 In SP Pagebuilder - Question | JoomShaper
Black Friday sale is live with flat 50% OFF. Sale ends soon! Grab your deal now!

JQuery V1.12.4 In SP Pagebuilder

PT

Paul Trouw

SP Page Builder 4 years ago

Hi, By default the /components/com_sppagebuilder/assets/js/jquery.min.js is loaded. This is jQuery v1.12.4 which is old and vulnerable. Can I just delete it? Or what to do? Joomla 4 already uses: /media/vendor/jquery/js/jquery.min.js?3.6.0

0
25 Answers
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #51459

yes, we removed file which wasn't used.

If you have it, you can delete it.

But if you have custom template make extra tests and in case of load jquery from Joomla 4.x core.

0
Ofi Khan
Ofi Khan
Accepted Answer
Support Agent 4 years ago #45396

Hello Paul Trouw

Thanks for reaching out to us. There might be some dependencies with the JQuery version. So, I do not recommend you to delete it. If you want, you can test deleting it on your local environment. But please do not delete it on your production sites yet. I have forwarded the request to update the JQuery version to the development team.

Best regards

0
PT
Paul Trouw
Accepted Answer
4 years ago #45500

For now I have renamed it. Everyting still seems to work. BTW I am using J4. And Lighthouse is flaging jQuery v1.12.4 with 4 security risks. I will wait your answer from the development team.

0
Ofi Khan
Ofi Khan
Accepted Answer
Support Agent 4 years ago #45617

It is already in Dev's table. Hopefully, they will update it in the next version. Thanks for your feedback.

0
V
Vassilis
Accepted Answer
3 years ago #47682

Hi!

I faced the same problem in joomla 4. JQuery 1.12.4 is very obsolete and you should delete it asap, especially since Joomla core loads the 3.6.0 version of the script!

I was forced to strip it with jQuery Easy. At least you could add the ability for the user to disable it.

Wasn't it enough for you that you're bloating the html with tons of useless code, you thought that you should be loading JQuery library twice?

You guys are moving extremely slow and losing clients, with me being one of them. I'm already moving my projects to your competitors.

0
PT
Paul Trouw
Accepted Answer
3 years ago #50917

Hi, has this been fixed already?

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #50920

I will ask our developer right now,

but remember that file also exist in joomla 3.10 core (!)

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #50924

Our developer promised to take a look at this, probably this file is not used anymore.

but I am not sure if during component update Joomla can delete not used file, so I have concern only about it.

0
V
Vassilis
Accepted Answer
3 years ago #50934

Our developer promised to take a look at this

It is already in Dev's table

Blah blah blah

probably this file is not even used anymore

I'm afraid you don't know much about your porduct. The file is heavily used by the extension. I can name some SP Page Builder addons that make use of JQuery 1.12.4, like open street map, accordion etc

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #50946

@Vassilis

Why you have to be so rude here? Do you answer in this same way to your clients? I doubt.

Don't forget that Joomla have its own JQuery file in Joomla 3 and Joomla 4, so we don't have to load that file from component folder, but from joomla core in case of. I am nor developer , but I know that it can be solved somehow in a good way. Temporary, a file replacement can be a solution. For countdown, popup etc there are separate .js files.

0
V
Vassilis
Accepted Answer
3 years ago #50979

@Paul Frankowski

This thread is open for more than a month, and you keep saying that your developers will take a look.

You're calling me rude, but in fact, you're rude and fooling your clients.

You are selling an extension based on an outdated and vulnerable jQuery version, and you guys have no plan of moving forward.

As you said, Joomla has its own jQuery file but most of your add-ons are based on jQuery 1.12.4, and they are loading component's file whenever they are used.

What do you mean by file replacement? Delete or rename your file? This is not a solution for me. As I said, many add-ons are based on jQuery 1.12.4 and if it's not loaded they don't work. Your developers have to recode all those add-ons as well as the whole code the component produces, which is bloating the HTML with useless code.

As I already said, after many years of using SP Page Builder Pro, your behavior and unwillingness of moving forward are pushing me away and sending me to your competitors. FYI, from now on, all my new projects are based on another page builder and not on yours.

Your rude client.

0
PT
Paul Trouw
Accepted Answer
3 years ago #51446

SP Page Builder v3.8.3 Changelog:

Update: Dropped old jQuery file

0
V
Vassilis
Accepted Answer
3 years ago #51524

Realy nice!

But many add-ons are not working now hahaha

Whatever...

Sorry for being rude!

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #51526

Let me check on my end. You're not rude, not at all, but please deliver more details. Yesterday we made some tests.

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #51528

My addons tests (today, extra ones, on J3.10, Helix) without old jQuery file:

  1. Accordion addon - still works,
  2. Slideshow - OK
  3. Progress bar - OK
  4. Testimonial Carousel - OK
  5. Open Street Map (Voyager Map) - OK
  6. Team Carousel - OK
  7. Modal Popup - ok

I don't see any not working addon.


Wikimedia map, it doesn't work for a long time, so please do not consider it.

0
V
Vassilis
Accepted Answer
3 years ago #51529

A few I've checked are:

  • open street map
  • accordion
  • image lightbox

They are not working on J4.05

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #51538

On Joomla 3.10 are OK. but Yes I will test on Joomla 4 as well. thx

0
V
Vassilis
Accepted Answer
3 years ago #51541

Your devs should have checked before releasing the update

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #51546

Joomla 4.0.5 still OK, Accordion addon (two styles) and OSM (Voyager)

foto_7568_2022.jpg

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #51548

Image addon - Open in Lightbox - still works.

Sorry, but I cannot emulate your issues.

foto_7569_2022.jpg

maybe use 2nd website, with clean Joomla and SPPB only.

0
V
Vassilis
Accepted Answer
3 years ago #51552

It's not working on my end. You can check the english section of the site I've sent you.

On the other 2 languages I'm loading jQuery manually through the template.

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #51553

Can you check on Cassiopea template, on your side?

If wil not work as well, let me know. Otherwisewe you have to load jquery from Joomla 4.x core:

media\vendor\jquery\js\jquery.min.js

It's safest method.

0
V
Vassilis
Accepted Answer
3 years ago #51560

It is probably a conflict with astroid framework. It works on Cassiopeia

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 3 years ago #51567

In that case all is clear. Load jquery from Joomla 4.0.x core if this may help.

0
V
Vassilis
Accepted Answer
3 years ago #51569

Joomla's Jquery is loaded by default but SP page builder's add-ons still need jQuery 1.12.4 in order to work.

I'm getting the following error in console

Uncaught TypeError: Cannot read property 'fn' of undefined
    at sppagebuilder.js?4c712525bbbcd041da9d1cec623f871f:7
    at sppagebuilder.js?4c712525bbbcd041da9d1cec623f871f:7
Uncaught TypeError: jQuery is not a function
    at initOpenStreetMap (leaflet.provider.js:1)
    at leaflet.provider.js:1
    at dispatch (jquery.min.js?3.6.0:2)
    at v.handle (jquery.min.js?3.6.0:2)

but when I switch to Cassiopeia everything works fine with no console errors

Right now I'm checking the astroid's scripts for any conflict with SP page builder

*Update:

No conflict with Astroid.

0