Image Overlay Add-on Bug - Question | JoomShaper

Image Overlay Add-on Bug

A

Addington

SP Page Builder 4 years ago

Sp Page Builder Version: 3.7.10 There is a small bug on the margin settings for subtitles in image overlay.
Only the tablet version is effected (desktop and mobile are fine). The bug is that you have to enter the margin for subtitles on a tablet as 5px 5px 5px 5 (NB no "px" on right hand margin).

If you do this, then you won't get a W3C validation error. If you add "px" to the right margin, you will get an error because the program automatically adds px to the end.

Example:- if you input 1px 2px 3px 4px, web browsers will read {margin: 1px 2px 3px 4pxpx}

Versions: Sp Page Builder: 3.7.10 Helix ultimate Template: 1.1.3 PHP Built On Linux 3.10.0-1127.19.1.el7.x86_64 #1 SMP Tue Aug 25 17:23:54 UTC 2020 x86_64 Database Type mysql Database Version 5.6.48-88.0 Database Collation utf8_general_ci Database Connection Collation utf8mb4_general_ci PHP Version 7.3.27 Web Server Apache WebServer to PHP Interface fpm-fcgi Joomla! Version Joomla! 3.9.27 Stable Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36

0
6 Answers
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 4 years ago #20360

fixed. I made addon override inside template folder, so you don't have to be worred about SPPB updates in case of. Sorry for our code mistake.

I edited site.php file, in line 322 where I removed "px" value used for $sub_title_margin_sm.

foto_6251_2021.jpg

1
Ariba
Ariba
Accepted Answer
Support Agent 4 years ago #19665

Hello

Thank you for your query & the credentials. I will check from my end and get back to you.

0
A
Addington
Accepted Answer
4 years ago #19671

This is an extract of the watchful SEO report on this page (the third error mentioned but not listed relates to Helix Ultimate - a different problem!)

The W3C validator found 3 errors in your page. This can lead to wrong interpretations by WEB Crawlers and unexpected issues with some browsers. Errors (3) Line Source Message 35 x 0px 0px 0pxpx;}#spp CSS: “margin”: Unknown dimension. 35 e {margin:px;}#spp CSS: “margin”: “px” is not a “margin” value.

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 4 years ago #20358

Hi, if I may... In general, if you use padding or margin always you have to add "px" "%" "rem" or other value - do not leave only numbers.

I will check your site and addon in next minutes. Maybe indeed there is a small issue.

0
Paul Frankowski
Paul Frankowski
Accepted Answer
Senior Staff 4 years ago #20359

OK, I can confirm issue. I will try to fix it on your site and we will inform developers.

0
A
Addington
Accepted Answer
4 years ago #20538

Thank you for resolving this.

0