Black Friday 2026 50% off every plan Our biggest deal of the year on #1 Joomla products.
Ends in 13d 05h 49m 58s
Claim 50% off
Staff replied Helix Framework Joomla 6 v6.2

Few issues and questions

Asked by Goran 2 days ago Last activity 2 days ago

Hello

thanks again for 2.2.11 and for fixing most of what we reported earlier. Since then we have gone through the 2.2.11 plugin and the shaper_helixultimate template on our site (Joomla 6.2.0, PHP 8.5.12) and collected the things below. None of them repeats what we reported before, except where we say so. Most of it comes from reading the code; where we actually tried something, we mention it. Line numbers refer to the installed 2.2.11 files.

It turned into a long list, sorry about that. We grouped it by area, so it is easier to pass parts of it on.

TEMPLATE PACKAGE

  1. The compiled template.css looks like it is still from 2.2.10
    css/template.css in 2.2.11 is the same file as in 2.2.10 (same size, same md5), but scss/theme.scss did change: the sticky logos are now hidden by default (:493-496), the desktop sticky rules moved into a min-width: 992px media query (:509-517), and there are new rules for .logo-sticky-mobile and .logo-mobile-default (:520-528), which features/logo.php uses (:153, :185, :192). None of that is in the shipped CSS. It still has the old '#sp-header.header-sticky .logo-sticky{display:block !important}' and '#sp-header.header-sticky .logo-default{display:none !important}'.
    add_scss() only compiles when "Compile SCSS to CSS" is on (src/Core/HelixUltimate.php:1120), and the option text recommends turning it off in production, so a site that follows that advice gets the old CSS. Reading the CSS, the mobile sticky logo would then be visible next to the main logo, because nothing hides it (its classes at logo.php:192 don't include d-lg-none). We haven't checked this in a browser. Is the compiled file meant to be regenerated for each release?

While looking at this we also noticed that theme.scss:3 and responsive.scss:27 and :139 write '--header_height: $header_height' without #{...}. The shipped CSS really contains the text '$header_height', so var(--header_height) ends up invalid where it is used (theme.scss:148, :539-540, :920). And a small one: options.json:121 has scssoption "1", while options.xml:1916 has default="0".

2. The rating spinner never shows up

js/main.js looks for '.fa-spinner' (:325 and :330), but the rating layout prints a span with 'fas fa-circle-notch fa-spin' (overrides/layouts/joomla/content/rating.php:36, the same in overrides_legacy). So the span stays hidden, and the .fa-spinner rule at theme.scss:1726 has nothing to style. It is the same rating widget whose missing token we reported earlier and you fixed in 2.2.11.
When the selector gets fixed, it would be good to hide the spinner on failure too. Right now hide() only runs in success, after $.parseJSON(response) (:328), and there is no error handler, so a non-JSON answer (for example the redirect Session::checkToken() does for a new session, libraries/src/Session/Session.php:76-79) would leave it spinning. dataType: 'json' plus an error callback would cover both. In the same callback, a rejected vote returns no rating_count (helper.php:25-28, :37-38, :43-44), so the counter shows "(undefined)" (main.js:337). Simply adding the fa-spinner class to the span would change the icon, because .fa-spinner:before comes after .fa-circle-notch:before in css/font-awesome.min.css.

3. Escaping in features/logo.php

The new mobile sticky logo (logo.php:192-193) puts Uri::root() . $mobileStickyLogo into src without htmlspecialchars. The value is the style parameter mobile_sticky_logo (:102), which the customizer saves with getArray() and trim() only (src/Platform/Request.php:408-442). Only users with core.edit on com_templates can save it, and they can already add raw before_head and custom_js, so we don't see a vulnerability here and did not try to exploit it. It is more about consistency: the same file already escapes the alt text (:111) and the custom link (:117), and the Joomla manual (security/common-vulnerabilities.md, "Escape the output") recommends htmlspecialchars() outside component views. The other image paths in the file follow the same pattern (:130, :138, :140, :170, :187, :206-207, :211), and so does the text logo (:291, :295, :300). The logo heights (:218 onwards) only get a unit check before they go into addStyleDeclaration().

MEGA MENU, MENU BUILDER AND MEDIA MANAGER

  1. Raw language key in the mega menu toast
    After saving mega menu settings, megamenu.js calls Joomla.Text._("HELIX_ULTIMATE_MEGAMENU_SETTINGS_SAVED"), and "..._SAVE_FAILED" for the error. Both keys are in the plugin language file (:113-114), but registerLanguageScripts() in src/Platform/Platform.php only pushes HELIX_ULTIMATE_TOAST_MEGAMENU_SETTINGSSAVED (:323). Of the 27 keys the admin scripts read, these are the only two without Text::script(), and in that case Joomla.Text.() returns the key itself (media/system/js/core.js:327-329). Registering them, or switching to the TOAST_ keys that are already registered, would do it.

5. Success toast after a failed mega menu save

We reported earlier that a failed mega menu save still looked successful, and thanks for making saveMegaMenuSettings() return the real status (src/HttpResponse/Response.php:316). On the JS side there is still a complete() callback that always closes the modal and shows the green "Saved mega menu settings!" toast, and jQuery runs complete after success and after error alike (jQuery 3.7.1, media/vendor/jquery/js/jquery.js:9627-9642). So after a failed save the admin sees the red toast, then the green one, and the modal closes with the changes gone. Our earlier suggestion only looked at the PHP side, sorry about that. Moving closeModal() and the success toast into the status:true branch would fix it.

6. The mega menu of an unpublished menu item can't be saved

saveMegaMenuSettings() looks the item up through SiteMenu (Response.php:265-266), which only loads published items within their publish dates (libraries/src/Menu/SiteMenu.php:138-160). The builder, however, lists unpublished items too (Response.php:154), and MegaMenuBuilder::getMenuItem() loads by id without a state filter (src/Platform/Builders/MegaMenuBuilder.php:95-110). So you can open and edit the mega menu of an unpublished or scheduled item, but saving always answers "Menu item not found" (Response.php:268-272). Is that on purpose? If not, reading the item by id the way MegaMenuBuilder does would work, and it also gives you menutype. That message is also the only one in the method hard-coded in English; the others go through Text::_() (:261, :305, :318).

7. Toaster and innerHTML

assets/js/admin/toaster.js puts the title and the message straight into innerHTML. One caller, menubuilder.js, passes Joomla's own system message markup (u.html()), and that message contains the title of another menu item (JLIB_DATABASE_ERROR_MENU_UNIQUE_ALIAS, libraries/src/Table/Menu.php:250). We couldn't turn this into an actual injection, and plain escaping would break these messages. Core shows the same messages through Joomla.sanitizeHtml() (media/system/js/messages.js:282 and :290), which keeps a, strong, em and p, so doing the same in the toaster would be a cheap safety net. One detail: sanitizeHtml() reads .length of its argument (core.js:45), so wrapping the value in String() avoids an error when it is undefined.

8. Upload messages in the media manager

uploadMedia() in src/Platform/Media.php returns COM_SPPAGEBUILDER_MEDIAMANAGER* keys (:295, :306, :356, :360) that only exist in the template language file (en-GB.tpl_shaper_helixultimate.ini:517-520). The upload request is answered in onAfterRoute and ends with exit and die() (helixultimate.php:491-498, Platform.php:191-192), while the template language is loaded in loadFrameworkSystem() (Platform.php:227), which runs from onAfterDispatch (helixultimate.php:581). So we are not sure the template language is loaded at all for this request; if it isn't, the alert would show the raw key. Could you check that?
In the same method, a file larger than upload_max_filesize arrives with error 1, so the UPLOAD_ERR_OK block (:283) is skipped and the admin gets the initial JERROR_ALERTNOAUTHOR message (:270), which says they are not authorised. That is a bit confusing. The error 1 check on :304 sits inside that block, so it can never match.

MENU BUILDER AJAX RESPONSES (src/HttpResponse/Response.php)

9. parentAdoption() and database errors

If updateObject() or rebuild() throws, the catch block echoes the exception text (:69-83) and the method still returns status true, so the response becomes that text followed by the JSON from Request.php:226. That is not valid JSON (json_decode() returns NULL on PHP 8.4 and 8.5, we checked), so JSON.parse() in menubuilder.js throws and the drag and drop never finishes. If only the echo were removed, the status true would let the script carry on as if the new parent had been saved. Logging the exception and returning the real result, as saveMegaMenuSettings() now does (:315-316), would cover both. We did not actually provoke a database error, this is from reading the code.

10. parentAdoption() with missing values

$data is only created inside "if ($itemId > 0 && $parentId > 0)" (:64-65) but returned in any case (:80-83). A request without a valid id or parent gets "Undefined variable $data" and {"status":true,"data":[null]} (we tried the same control flow on PHP 8.4). The builder always sends both values, so it only matters for malformed requests.

11. getMenuItems() and database errors

getItems() echoes the exception text in the same way (around :160), and getMenuItems() (:43-49) still returns status true. The getMenuItems call in menubuilder.js has no error callback and no branch for status false, so on a database error the builder would just stay empty without any message.

CUSTOMIZER PREVIEW TOKEN AND THE HELIX CACHE

12. The preview token runs out quietly

The token lives for 60 minutes (src/Platform/Helper.php:42) and is created only when the customizer opens (Platform.php:143-150). After that, isAuthorizedPreview() returns false (Helper.php:303-306) and the preview falls back to the saved settings instead of the draft (Helper.php:388-390), without a notice. As far as we can read the code, someone who keeps the customizer open for more than an hour would see their changes vanish from the preview. Returning a fresh token with the draft and save responses, or at least showing a notice, would help. We wouldn't extend the token on every use, because of the next point.

13. Is the token meant to work without a session check?

createPreviewToken() stores only the style id (Helper.php:263-267), and isAuthorizedPreview() checks the mode, the format and the style (Helper.php:283-320), but not the user or the session, and it doesn't remove the entry after use. So anyone who has the URL can open the preview for 60 minutes. The token has 256 bits, so this is only about a URL that leaks somewhere. helix-ultimate.js also copies helixPreview onto the links in the preview, and the referrerpolicy on the iframe (layouts/preview/iframe.php:44) only covers the iframe request itself. Is this the intended design? Invalidating the token when the draft is saved or reset, and sending Referrer-Policy: no-referrer with an authorised preview, might be worth a thought.
A correction to our earlier follow-up: we called it a "one-time token" there, which isn't right. It can be reused for 60 minutes.

14. Unknown tokens leave empty files in cache/helixultimate-preview

This one we did reproduce. isAuthorizedPreview() passes any well-formed 64-hex token to HelixCache::loadData() (Helper.php:293-306, src/System/HelixCache.php:204-214), also for guests. HelixCache uses the output cache controller, whose get() takes a lock on a cache miss (libraries/src/Cache/Controller/OutputController.php:55-56), and FileStorage::lock() opens the file with fopen(..., 'c+b') (FileStorage.php:333), which creates it empty. unlock() then drops it from the list of locked files (:381-390), so the cleanup at shutdown (:62-80) leaves it behind. When we opened a page as a guest with helixPreview set to 64 "a" characters, and then to 64 "b" characters, each request left one 0-byte file, named exactly like the cache file of that token. Checking $cache->contains() first, which doesn't lock or create anything, should be enough.

15. Old token files are never removed

Every time the customizer opens, a new token file is written (Helper.php:263-267), and FileStorage only deletes an expired file when the same key is read again (FileStorage.php:413-421), which never happens for an old token. The ones from yesterday are still in our folder. Deleting files in that group that are older than the token lifetime, whenever a new token is created, would keep it clean. Cache::gc() is not a good fit here, because it would also remove the 24-hour init and draft entries.

16. The cache folder

HelixCache.php:118 uses $config->get('cache_path', JPATH_ROOT . '/cache'), while Joomla's default is administrator/cache (includes/defines.php:23, libraries/src/Cache/Cache.php:57, and the manual in general-concepts/cache/caching-views-modules.md:41). With an empty "Path to Cache Folder", Helix writes into cache/ in the web root, where Clear Cache, Clear Expired Cache (administrator/components/com_cache/src/Model/CacheModel.php:171-179, :261) and the cache:clean command (libraries/src/Console/CleanCacheCommand.php:55-70) never look. Is that intentional? If you switch to JPATH_CACHE, keep in mind that Clear Expired Cache uses the global cache time and would then remove drafts and tokens early.

OVERRIDES AND LAYOUTS

17. Mega menu badge and "<"

Thanks for fixing the double encoding we reported earlier, "New &amp; hot" shows correctly again. As a side effect, sanitizeMegaMenuBadge() (Helper.php:1366-1371) now cuts the text after a lone "<". With joomla/filter 4.1.1 on PHP 8.4 and 8.5, "a < b" becomes "a", "5 < 10 days" becomes "5 0 days" and "1 < 2 > 0" becomes "1 0". The method runs on save (Helper.php:1298), so the shortened text is what gets stored, and again on render (src/Core/Classes/HelixultimateMenu.php:737) before htmlspecialchars() (:756). It comes from the non-terminated tag branch in InputFilter (libraries/vendor/joomla/filter/src/InputFilter.php:385-388). In a quick test, trim(strip_tags(html_entity_decode($value, ENT_QUOTES | ENT_HTML5, 'UTF-8'))) kept all three examples and still turned "New &amp; hot" into "New & hot". Neither version keeps a "<" that is directly followed by a letter or a digit, though.

18. Breadcrumbs JSON-LD

The Helix breadcrumbs override (overrides/mod_breadcrumbs/default.php:121) differs from core 6.2.0 (modules/mod_breadcrumbs/tmpl/default.php:121-133) in two small ways. Core names the inline script 'inline.breadcrumbs-schemaorg', and the core System - Schema.org plugin looks for exactly that name (plugins/system/schemaorg/src/Extension/Schemaorg.php:400-403) and quietly skips the breadcrumbs when it doesn't find it (:419-421). Without a name, WebAssetManager uses 'inline.' plus an md5 (WebAssetManager.php:694). Core also adds the JSONHEX* flags; the names are already escaped by BreadcrumbsHelper (:52, :84), so that part is only about staying in line with core. We have only read this, the Schema.org plugin is off on our site.

19. Video layout: iframe without a title

In overrides/layouts/joomla/content/blog/video.php:121 the YouTube, Vimeo and Dailymotion iframe has no title, so screen readers announce it without a name. Core gives its own iframe one (modules/mod_wrapper/tmpl/default.php:27), and the Joomla manual asks extensions to follow WCAG 2.2 AA (accessibility/index.md:11). The layout only receives attribs (article/default.php:98, category/blog_item.php:59), so a translated generic title would not need any changes in the callers. The generic iframe at :102 has the same gap, but there sanitizeEmbed() would strip a title anyway, which we already mentioned in our earlier follow-up about sanitizeEmbed().

20. Video layout: English fallback text

video.php:96 has "Your browser does not support the video tag." hard-coded. Other layouts use language keys for text like this (for example blog/authorinfo.php:36), and so does core (Text::('MOD_WRAPPER_NO_IFRAMES') in modules/mod_wrapper/tmpl/default.php:29).

GETTING READY FOR JOOMLA 7

21. The customizer would break on Joomla 7

This is probably the most important one in this group. For administrator com_ajax requests with helix=ultimate, onBeforeCompileHead() builds the method name 'sanitizeAssetsForJ' . JoomlaBridge::getVersion('major') and calls it (helixultimate.php:590-594). Only J3 to J6 exist (:636, :682, :716, :751) and the class has no __call(), so on Joomla 7 the customizer would end with "Call to undefined method ...::sanitizeAssetsForJ7()". We checked the PHP side with the same kind of dynamic call. The comment at :592 and the docblocks at :710 and :745 still mention Joomla 3 and 4.

22. Calls that Joomla 7 removes

  • Factory::getDocument() (Factory.php:321-324), for example in features/logo.php:77, together with six $doc->addStyleDeclaration() calls (:225 to :283, Document.php:637-639). We count 76 lines with getDocument() in 52 files of the plugin and the template.
  • Cache::getInstance() (Cache.php:90-92) and Factory::getConfig() (Factory.php:178-181) in src/System/HelixCache.php:123 and :114. All Helix caching goes through this class, and it is created on every site page through onBeforeCompileHead and onAfterRender (helixultimate.php:587, :800). getConfig() also appears in overrides/com_content/article/default.php:77 and overrides/layouts/joomla/content/open_graph.php:18, and the manual lists it among the calls that will only keep working with the compatibility plugin (updates/64-70/removed-backward-incompatibility.md:12 and :20).
  • Factory::getDbo() (Factory.php:446-449): 22 lines in 18 files. 14 lines in 11 files are in current code, the rest only runs below Joomla 4 or 5, and 3 of the 14 are in the old fields/ folder we mentioned in an earlier report. The plugin already uses the DI container in a few places (helixultimate.php:341, :367, src/fields/helixmegamenu.php:85). Factory.php:230-232 says that swapping in getContainer()->get() one for one isn't the intended migration, so this one is probably more of a refactor.

23. $app->input (removed in 8.0)

Not urgent, but worth having on the list: src/Platform/Helper.php reads $app->input in 8 lines, and the plugin has 79 more in 23 files outside overrides_legacy. WebApplication.php:466-483 marks it for removal in 8.0 and triggers a deprecation on each access (manual: updates/54-60/new-deprecations.md:16).

24. JVERSION compared with numbers

We mentioned these comparisons in an earlier report, and thanks for switching HTMLOverride.php:100 and :155 to version_compare(). There are still 13 places that compare JVERSION with a plain number: helixultimate.php:74, :398, :764, :852; src/Core/HelixUltimate.php:255, :363, :381, :386, :407, :536, :1562; layouts/masonry/bloglist.php:39; overrides/layouts/com_contact/joomla/form/renderfield.php:18. JVERSION is a string, so PHP compares them as strings, and on PHP 8.4 "10.0.0" < 4 is true while "10.0.0" >= 4 and >= 6 are false. Nothing goes wrong before Joomla 10, but since the plugin already uses version_compare() in 19 places, it might be simplest to do the rest the same way.

25. One docblock

getHeaderStyle() is documented as "@return void" (src/Core/HelixUltimate.php:1711), but it returns the rendered layout (:1735), and the template's index.php:159 echoes it, so static analysers complain. getOffcanvasStyle() already says "@return string".

That's all from our side. Thanks for taking the time to go through it, and we are happy to test a build or send more details on any of these.

Best regards.

1 reply

Paul Frankowski Senior Staff

Hi,
Thanks for all the details. I already shared with the developers.

Log in to reply.